Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking][Waiting to merge] &Option<T> -> Option<&T> in nccl broadcast. Add Option argument to nccl reduce. #292

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Breaking][Waiting to merge] &Option<T> -> Option<&T> in nccl broadcast. Add Option argument to nccl reduce. #292

wants to merge 2 commits into from

Conversation

coreylowman
Copy link
Owner

Resolves #290

@coreylowman coreylowman changed the title [Breaking] &Option<T> -> Option<&T> in nccl broadcast. Add Option argument to nccl reduce. [Breaking][Waiting to merge] &Option<T> -> Option<&T> in nccl broadcast. Add Option argument to nccl reduce. Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should nccl::broadcast take a Option<&T> instead of an &Option<T>?
1 participant
@coreylowman